Comments on: Next time you check-in code, think about it http://isanchez.net/2009/10/22/next-time-you-check-in-code-think-about-it/ Software Craftsman Sat, 19 Dec 2009 02:49:20 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: JaeRae http://isanchez.net/2009/10/22/next-time-you-check-in-code-think-about-it/comment-page-1/#comment-8544 JaeRae Thu, 22 Oct 2009 20:46:36 +0000 http://isanchez.net/?p=288#comment-8544 Today I wrote my check in comment in French to amuse the guy I'd been sat next to all day because we needed some levity after deciding not to refactor more into a DDD design as it would break the anemic model that we currently use. if we passed in it's collaborators it would require a rewrite of it's tests and 6 or 7 other classes and their tests and become 1 or 2 day's work.... *Sad Face* still, got a laugh out of my poor french. especially when Sebastien noticed and corrected it..... Today I wrote my check in comment in French to amuse the guy I’d been sat next to all day because we needed some levity after deciding not to refactor more into a DDD design as it would break the anemic model that we currently use. if we passed in it’s collaborators it would require a rewrite of it’s tests and 6 or 7 other classes and their tests and become 1 or 2 day’s work….
*Sad Face*
still, got a laugh out of my poor french. especially when Sebastien noticed and corrected it…..

]]> By: Thiago Arrais http://isanchez.net/2009/10/22/next-time-you-check-in-code-think-about-it/comment-page-1/#comment-8538 Thiago Arrais Thu, 22 Oct 2009 17:17:00 +0000 http://isanchez.net/?p=288#comment-8538 I do agree with your approach and I don't know why anyone would disagree. I personally have to take a deep breath to control myself when I see a commit message that looks like "changed routine X". I can't help thinking "Dude, I know you changed routine X by looking at the diffs, you have to tell me <em>why</em> on earth you changed it!" I do agree with your approach and I don’t know why anyone would disagree. I personally have to take a deep breath to control myself when I see a commit message that looks like “changed routine X”. I can’t help thinking “Dude, I know you changed routine X by looking at the diffs, you have to tell me why on earth you changed it!”

]]>